Add ETag to failed conditional GETs

Found via s3-tests. References apache/jclouds#209.
gaul · Sep 4, 2024 · cb443b7 · cb443b7
1 parent 3d2beb3
commit cb443b7
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/main/java/org/gaul/s3proxy/S3ProxyHandlerJetty.java b/src/main/java/org/gaul/s3proxy/S3ProxyHandlerJetty.java
@@ -23,6 +23,7 @@
 import javax.annotation.Nullable;
 
 import com.google.common.collect.ImmutableMap;
+import com.google.common.net.HttpHeaders;
 
 import jakarta.servlet.http.HttpServletRequest;
 import jakarta.servlet.http.HttpServletResponse;
@@ -94,6 +95,12 @@ public void handle(String target, Request baseRequest,
                         hre.getMessage());
                 return;
             }
+
+            String eTag = hr.getFirstHeaderOrNull(HttpHeaders.ETAG);
+            if (eTag != null) {
+                response.setHeader(HttpHeaders.ETAG, eTag);
+            }
+
             int status = hr.getStatusCode();
             switch (status) {
             case 412:
@@ -111,7 +118,7 @@ public void handle(String target, Request baseRequest,
                 break;
             default:
                 logger.debug("HttpResponseException:", hre);
-                response.sendError(status, hre.getContent());
+                response.setStatus(status);
                 break;
             }
             baseRequest.setHandled(true);