Update TimeZoneDefinition.ts to fallback to parsing when mapping fails #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse TimeZoneInfo as a fallback to simple timezone mapping
marcoancona
changed the title
|
good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Events that do not provide a standard timezone id (e.g. we see a lot of events with Id
Customized Time Zone) currently do not provide a way to access the definition of the timezone. In this case,TimeZoneisCustomized Time ZoneandStartTimeZoneisundefined. Afaik, there is no way to access the timezone parameters.This PR is to fallback to timezone parsing when mapping fails. @gautamsi what do you think about this?
PS: events with "Customized Time Zone" are not only edge cases. iOS creates events with this kind of timezone!