Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip swig for windows gazebo source install #497

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

knmcguire
Copy link
Contributor

@knmcguire knmcguire commented Sep 4, 2024

🦟 Bug fix

Related to this issue in gazebo testing: gazebosim/gazebo_test_cases#1701

Summary

If installed with the original instructions:

colcon build --cmake-args -DBUILD_TESTING=OFF --merge-install --packages-up-to gz-sim9 gz-tools2

I get

...\miniconda3\envs\gz-ws\include\ruby-3.3.0\x64-mswin64_140\ruby\config.h(4,1): error C1189: #error:  MSC version unmatch: 1920..1939 is expected. [C:\Users\kimbe\Development\simulation\gazebo\gz-ws\build\gz-math8\src\ruby\rbmath.vcxproj]
  (compiling source file '../../lib/ruby/Vector3RUBY_wrap.cxx'

Among other issues. It seems that Ruby is quite picky with the MSC versions but I couldn't find a version of Ruby to go around this, and I don't think it is feasible to update the MSC version that needs to be updated to satisfy ruby's restrictive requirements. @azeey suggested to build the workspace with:

colcon build --cmake-args -DBUILD_TESTING=OFF -DSKIP_SWIG=ON --merge-install --packages-up-to gz-sim9 gz-tools2

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Kimberly N. McGuire <kimberly@bitcraze.io>
@ahcorde ahcorde merged commit ec18438 into gazebosim:master Sep 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants