Unset DELETE method on Windows #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about renaming it already? Maybe |
18 tasks
nkoenig
approved these changes
Jan 25, 2021
chapulina
suggested changes
Jan 25, 2021
| @@ -29,6 +29,8 @@ | |||
| // std::string | |||
| #pragma warning(push) | |||
| #pragma warning(disable: 4251) | |||
| // TODO: rename the DELETE method which is a reserved word in Windows | |||
There was a problem hiding this comment.
codecheck is failing:
/github/workspace/include/ignition/fuel_tools/RestClient.hh:32: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
/github/workspace/include/ignition/fuel_tools/Result.hh:31: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
…ls into win_delete Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 77.85% 77.85%
=======================================
Files 19 19
Lines 2606 2606
=======================================
Hits 2029 2029
Misses 577 577
Continue to review full report at Codecov.
|
chapulina
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete is a reserved word on Windows. This PR runs the workaround of unset it so the ResultType class can compile. To real fix the problem I think that we need to plan a migration from using the reserved word to another (REMOVE or something like that)