Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for 10.0.0~pre4 Release #388

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Prepare for 10.0.0~pre4 Release #388

merged 1 commit into from
Sep 28, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 28, 2023

🎈 Release

Preparation for 10.0.0~pre4 release.

Comparison to 9.5.0: gz-msgs9_9.5.0...gz-msgs10

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey
Update changelog and prepare for pre4
97f0958 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from caguero as a code owner September 28, 2023 02:30
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 28, 2023
@azeey azeey requested a review from iche033 September 28, 2023 02:32
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #388 (ae0fc8d) into gz-msgs10 (a731933) will not change coverage.
The diff coverage is n/a.

❗ Current head ae0fc8d differs from pull request most recent head 97f0958. Consider uploading reports for the commit 97f0958 to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #388   +/-   ##
==========================================
  Coverage      97.26%   97.26%           
==========================================
  Files             27       27           
  Lines           1170     1170           
==========================================
  Hits            1138     1138           
  Misses            32       32

azeey
azeey commented Sep 28, 2023
View reviewed changes
Changelog.md
@@ -35,33 +43,11 @@
1. Added cubemap_uri to sky
* [Pull request #306](https://github.com/gazebosim/gz-msgs/pull/306)

1. Remove deprecated flag output_to_genfiles
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed these since they were added in gz-msgs9. For the 10.0.0 release, I'm only including changes are new to the gz-msgs10 branch.

@azeey azeey merged commit 146e399 into gazebosim:gz-msgs10 Sep 28, 2023
7 of 9 checks passed
@azeey azeey deleted the update_changelog branch September 28, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

@iche033 iche033 Awaiting requested review from iche033

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @mjcarroll