dartsim-plugin windows build fixes #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Build dartsim and test plugins with /permissive- with MSVC due to dartsim/dart#753 * Disable C4250 compiler warnings. * Create unversioned dartsim plugin by copy rather than symlink, since symlinks require extra permissions on Windows. This copies the TPE approach. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
JShep1
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Thanks, these fixes allow me to build against dart. Although, it should be important to note that ign-physics now won't compile since it uses @azeey / Ignition's fork (https://github.com/ignition-forks/dart) and not the standard dart master branch.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some fixes needed to compile against dartsim on Windows, as mentioned in #87. Though dartsim version 6.9.4 is now available in vcpkg, this version is missing some needed fixes (dartsim/dart#1510, dartsim/dart#1513), so I recommend building dart's
masterbranch from source in a colcon workspace alongside this branch. Unfortunately, dart still seems to have some runtime errors (dartsim/dart#1522), so all the tests that use thedartsim-plugincurrently fail, but at least the build succeeds.The fixes include:
check_test_ran.pyscript (based on ign-cmake's copy of this file)