Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Action for Windows and fix build #1049

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 31, 2024

🦟 Bug fix

Fixes #

Summary

Build failure was reported in gazebosim/gazebo_test_cases#1701 (comment). It looks like #1034 introduced the regression and since we don't have Ogre2 being tested on CI, we didn't catch it.

The first commit just adds GitHub action for windows as a temporary solution until we fix Jenkins.
Here's the failed Action from the first commit: https://github.com/gazebosim/gz-rendering/actions/runs/10642231243/job/29504381117?pr=1049

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from iche033 as a code owner August 31, 2024 03:56
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 31, 2024
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@iche033 iche033 merged commit 3ba2f1e into gazebosim:gz-rendering9 Sep 3, 2024
9 of 11 checks passed
@azeey azeey deleted the fix_windows_build branch September 3, 2024 19:03
@azeey azeey mentioned this pull request Sep 4, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants