Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport #1131] fix updating a component's data via SerializedState msg #1149

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

adlarkin
Copy link
Contributor

Signed-off-by: Ashton Larkin ashton@openrobotics.org

Note to maintainers: Remember to rebase

@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 27, 2021
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1149 (5c9b628) into ign-gazebo3 (c0ad543) will increase coverage by 0.20%.
The diff coverage is 55.00%.

❗ Current head 5c9b628 differs from pull request most recent head 3ab37ef. Consider uploading reports for the commit 3ab37ef to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3    #1149      +/-   ##
===============================================
+ Coverage        77.43%   77.64%   +0.20%     
===============================================
  Files              222      222              
  Lines            12797    12805       +8     
===============================================
+ Hits              9909     9942      +33     
+ Misses            2888     2863      -25     
Impacted Files Coverage Δ
src/EntityComponentManager.cc 89.09% <55.00%> (+4.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0ad543...3ab37ef. Read the comment docs.

Signed-off-by: Ashton Larkin <ashton@openrobotics.org>
@chapulina chapulina changed the title backport #1131 [backport #1131] fix updating a component's data via SerializedState msg Nov 9, 2021
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chapulina chapulina merged commit df06bb2 into ign-gazebo3 Nov 9, 2021
@chapulina chapulina deleted the adlarkin/backport_PR_1131 branch November 9, 2021 02:09
@chapulina chapulina mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants