-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support loading Projectors #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033
added
the
needs upstream release
Blocked by a release of an upstream library
label
May 2, 2023
ahcorde
requested changes
May 8, 2023
7 tasks
Signed-off-by: Ian Chen <ichen@openrobotics.org>
iche033
removed
the
needs upstream release
Blocked by a release of an upstream library
label
May 18, 2023
iche033
added
the
needs upstream release
Blocked by a release of an upstream library
label
May 18, 2023
still needs sdf13 release |
7 tasks
ahcorde
requested changes
May 19, 2023
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## gz-sim7 #1979 +/- ##
===========================================
- Coverage 65.03% 64.97% -0.06%
===========================================
Files 352 353 +1
Lines 28468 28600 +132
===========================================
+ Hits 18513 18583 +70
- Misses 9955 10017 +62
|
ahcorde
approved these changes
May 22, 2023
ahcorde
removed
the
needs upstream release
Blocked by a release of an upstream library
label
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Depends on
Summary
Added support for loading Projectors.
sdf::Projector
to / frommsgs::Projector
Test it
Added and updated various unit and integration tests
Run the demo world:
This should go and download the Camera with Projector from fuel. The model consists of 2 IR cameras, 1 IR pattern projector, and 1 RGB camera. The IR pattern should only be visible to the 2 IR cameras and invisible to the RGB camera.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.