Use common::setenv for portability to Windows #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
…ign-gazebo into jrivero/win/env_common Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
…ivero/win/env_common Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## main #561 +/- ##
==========================================
+ Coverage 77.57% 77.63% +0.05%
==========================================
Files 211 211
Lines 11582 11583 +1
==========================================
+ Hits 8985 8992 +7
+ Misses 2597 2591 -6
Continue to review full report at Codecov.
|
chapulina
approved these changes
Jan 20, 2021
chapulina
pushed a commit
that referenced
this pull request
Mar 3, 2021
Signed-off-by: Louise Poubel <louise@openrobotics.org>
7 tasks
chapulina
added a commit
that referenced
this pull request
Mar 8, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the ignition::common setenv to be able to work on Windows. Also added missing std:: namespaces to getenv.