Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove invalid visibility macros to fix Windows compilation #565

Merged
merged 6 commits into from
Jan 27, 2021
Merged

Remove invalid visibility macros to fix Windows compilation #565

merged 6 commits into from
Jan 27, 2021

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Jan 15, 2021 •
edited
Loading

The PR removes some not-needed/invalid visibility macros found in different situations:

  • Extern C functions
  • Executables, test or other binaries not designed to link against
  • Header only classes
  • Convert system to be a header only class

@j-rivero
Remove invalid visibility macros
e9ba573 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Jan 15, 2021
@j-rivero j-rivero marked this pull request as draft January 15, 2021 19:00
@j-rivero j-rivero mentioned this pull request Jan 20, 2021
Open
18 tasks
@j-rivero
Change system to be a header only file
84f1d31 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero force-pushed the jrivero/win/remove_visibility branch from dd11c72 to 84f1d31 Compare January 21, 2021 14:50
@j-rivero j-rivero marked this pull request as ready for review January 21, 2021 14:51
@codecov
Copy link

codecov bot commented Jan 21, 2021 •
edited
Loading

Codecov Report

Merging #565 (f077fbb) into main (63a88dc) will increase coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
+ Coverage   77.33%   77.38%   +0.05%     
==========================================
  Files         213      213              
  Lines       11951    11952       +1     
==========================================
+ Hits         9242     9249       +7     
+ Misses       2709     2703       -6
Impacted Files Coverage Δ
include/ignition/gazebo/components/Factory.hh 96.05% <ø> (ø)
src/ign.cc 72.18% <71.42%> (ø)
include/ignition/gazebo/System.hh 100.00% <100.00%> (ø)
src/SimulationRunner.cc 94.04% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a88dc...f077fbb. Read the comment docs.

chapulina
chapulina approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, thanks for all the pointers, these are good things to keep in mind for the entire stack.

@chapulina chapulina merged commit cd78bd4 into main Jan 27, 2021
@chapulina chapulina deleted the jrivero/win/remove_visibility branch January 27, 2021 06:17
@chapulina chapulina added the Windows Windows support label Jan 27, 2021
nkoenig pushed a commit that referenced this pull request Nov 8, 2021
Merged in aabb_dome (pull request #565)
34d2145 
AABB to Dome

Approved-by: Nate Koenig
Approved-by: Ian Chen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @chapulina