Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add light intensity field to ComponentInspector #670

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Add light intensity field to ComponentInspector #670

merged 2 commits into from
Mar 10, 2021

Conversation

atharva-18
Copy link
Contributor

@atharva-18 atharva-18 commented Mar 6, 2021 •
edited
Loading

Signed-off-by: Atharva Pusalkar atharvapusalkar18@gmail.com

🎉 New feature

Closes #637

Summary

I have added light intensity field to the ComponentInspector. Changes were also made to RenderUtil.cc and UserCommands.cc to set the light intensity value.
Here's a demo:
light_intensity

Test it

You can test the feature by running ign gazebo examples/worlds/lights.sdf

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@atharva-18
Add light intensity field to ComponentInspector
b1517cc 
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 6, 2021
ahcorde
ahcorde requested changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution!

Do you mind to add the intensity to the Plotting plugin ?

@atharva-18
Add intensity to plotting plugin
b145cb4 
Signed-off-by: Atharva Pusalkar <atharvapusalkar18@gmail.com>
@atharva-18
Copy link
Contributor Author

@ahcorde Added in b145cb4!

@chapulina chapulina added the rendering Involves Ignition Rendering label Mar 8, 2021
@ahcorde
Copy link
Contributor

ahcorde commented Mar 9, 2021

@osrf-jenkins retest this please

ahcorde
ahcorde approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting CI

@ahcorde ahcorde linked an issue Mar 9, 2021 that may be closed by this pull request
Allow to modify light intensity with the ComponentInspector - ign-gazebo5 #637
Closed
@ahcorde ahcorde mentioned this pull request Mar 9, 2021
Closed
chapulina
chapulina approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ahcorde
Copy link
Contributor

ahcorde commented Mar 10, 2021

@osrf-jenkins retest this please

@atharva-18
Copy link
Contributor Author

These tests are failing on macOS catalina:

The following tests FAILED:
	 83 - INTEGRATION_imu_system (SEGFAULT)
	113 - INTEGRATION_multiple_servers (SEGFAULT)
	139 - INTEGRATION_user_commands (SEGFAULT)

@ahcorde ahcorde merged commit f1bc04b into gazebosim:main Mar 10, 2021
@ahcorde
Copy link
Contributor

ahcorde commented Mar 10, 2021

Thank you for the contribution @atharva-18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice rendering Involves Ignition Rendering
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to modify light intensity with the ComponentInspector - ign-gazebo5
3 participants
@atharva-18 @ahcorde @chapulina