Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch execeptions from callbacks since it might cause a crash #443

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 22, 2023

🦟 Bug fix

Summary

Any exception by a callback might cause a crash in gz-sim (see gazebosim/harmonic_demo#14 (comment)), so it's best to catch it here and print a traceback.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

…d in gz-sim

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from caguero as a code owner September 22, 2023 18:56
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #443 (6d94adf) into gz-transport13 (d92aed2) will decrease coverage by 0.13%.
Report is 1 commits behind head on gz-transport13.
The diff coverage is n/a.

❗ Current head 6d94adf differs from pull request most recent head 00d393d. Consider uploading reports for the commit 00d393d to get more accurate results

@@                Coverage Diff                 @@
##           gz-transport13     #443      +/-   ##
==================================================
- Coverage           87.76%   87.64%   -0.13%     
==================================================
  Files                  59       59              
  Lines                5696     5696              
==================================================
- Hits                 4999     4992       -7     
- Misses                697      704       +7     

see 1 file with indirect coverage changes

@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 22, 2023
@azeey azeey merged commit 34079d0 into gazebosim:gz-transport13 Sep 22, 2023
7 of 9 checks passed
@azeey azeey deleted the catch_python_exception branch September 22, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants