Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #468 #470

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Fix issue #468 #470

merged 3 commits into from
Feb 2, 2024

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Jan 18, 2024

🦟 Bug fix

Fixes #468

Summary

As described in issue #468, the case of a Request() before an Advertise() when both calls are within the same process wasn't considered. This patch makes it work as in the case where requester and responser are in different processes (which was already working).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero requested a review from azeey January 18, 2024 20:46
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (764a04b) 87.80% compared to head (ec324d2) 87.83%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           gz-transport13     #470      +/-   ##
==================================================
+ Coverage           87.80%   87.83%   +0.02%     
==================================================
  Files                  59       59              
  Lines                5699     5704       +5     
==================================================
+ Hits                 5004     5010       +6     
+ Misses                695      694       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero merged commit 3a34f07 into gz-transport13 Feb 2, 2024
11 checks passed
@caguero caguero deleted the issue_468 branch February 2, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Service requester starting before responder causes timeout when both are in the same process
3 participants