Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ionic: Installation tutorial fixes #527

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Aug 29, 2024

🦟 Bug fix

Fixes minor issues in the Installation tutorial.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Comment on lines 295 to 298
If you're creating a new release, then tell gazebosim.org about
the new version. For example:
the new version. For example:
```bash
curl -k -X POST -d '{"libName":"transport", "version":"1.0.0", "releaseDate":"2017-10-09T12:10:13+02:00","password":"secret"}' http s://api.gazebosim.org/1.0/versions
curl -k -X POST -d '{"libName":"transport", "version":"1.0.0", "releaseDate":"2017-10-09T12:10:13+02:00","password":"secret"}' https://api.gazebosim.org/1.0/versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this completely since we're not using it anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation section tweaked in cbd0c1a

tutorials/02_installation.md Outdated Show resolved Hide resolved
caguero and others added 2 commits August 29, 2024 22:48
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Carlos Agüero <cen.aguero@gmail.com>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero changed the title Ionic installation tutorial fixes. Ionic: Installation tutorial fixes Aug 29, 2024
@caguero caguero merged commit f3ab342 into gz-transport14 Aug 29, 2024
10 checks passed
@caguero caguero deleted the ionic_installation_fix branch August 29, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants