Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python bindings for bullet and torsional friction #1427

Merged
merged 4 commits into from
May 30, 2024
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 30, 2024

🎉 New feature

Summary

Added python bindings for the new classes and functions added in #1351

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 30, 2024
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minimal change, otherwise LGTM

python/src/sdf/pySurface.cc Outdated Show resolved Hide resolved
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@ahcorde ahcorde merged commit ae0ca8e into sdf13 May 30, 2024
10 checks passed
@ahcorde ahcorde deleted the update_pySurface branch May 30, 2024 17:12
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Aug 16, 2024
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants