Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port embedSdf script from Ruby to Python3 and provide unittests #884

Merged
merged 15 commits into from
Feb 7, 2023
Merged

Port embedSdf script from Ruby to Python3 and provide unittests #884

merged 15 commits into from
Feb 7, 2023

Commits on Dec 17, 2022

  1. Add unittest for EmbeddedSpec with existing mappings 

    Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    4c05d18 View commit details
    Browse the repository at this point in the history

  2. Add unittest for EmbeddedSpec for non-existing mappings 

    this uses internal functions from GoogleTests
to capture the stderr message but according to the documentation
it should be fine to use them:
// All macros ending with _ and symbols defined in an
// internal namespace are subject to change without notice.  Code
// outside Google Test MUST NOT USE THEM DIRECTLY.  Macros that don't
// end with _ are part of Google Test's public API and can be used by
// code outside Google Test.
see https://github.com/google/googletest/blob/main/googletest/include/gtest/internal/gtest-port.h

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    814cfe2 View commit details
    Browse the repository at this point in the history

  3. Port embedSdf script from Ruby to Python3 

    - removes Ruby dependency (see gazebosim#274)
- improvements for cpplint checks (e.g. copyright header)

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    3901028 View commit details
    Browse the repository at this point in the history

  4. Hardcode separator in generated C++ mapping to '/' 

    it should not be operating system dependent because it is
hardcoded to '/' in the C++ file that performs the lookup

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    f7c502c View commit details
    Browse the repository at this point in the history

  5. Output variable to trace Windows issue 

    Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    59fb656 View commit details
    Browse the repository at this point in the history

  6. Revert "Output variable to trace Windows issue" 

    This reverts commit 2322458.

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    30fbd1d View commit details
    Browse the repository at this point in the history

  7. Refactor code to avoid GTest GetCapturedStderr 

    it's the same approach as in parser_TEST.cc

Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    f10c255 View commit details
    Browse the repository at this point in the history

  8. Use Python3_EXECUTABLE variable for command execution 

    Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    42c1cb0 View commit details
    Browse the repository at this point in the history

  9. Fix line length for cpplint 

    Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    468e0c0 View commit details
    Browse the repository at this point in the history

  10. Use multiline strings in combination with cleandoc 

    Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    37a4054 View commit details
    Browse the repository at this point in the history

  11. Use function argument variable 

    Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    26fcd31 View commit details
    Browse the repository at this point in the history

  12. Add changes for new SDF version 1.10 

    Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    25adf79 View commit details
    Browse the repository at this point in the history

  13. Use testing::RedirectConsoleStream to capture errors 

    Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    faf92e4 View commit details
    Browse the repository at this point in the history

  14. Make Python a build dependency 

    Signed-off-by: Bi0T1N <Bi0T1N@users.noreply.github.com>
    @Bi0T1N
    Bi0T1N committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    bbe6714 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Merge branch 'main' into embeddedsdf_refactoring

    @mjcarroll
    mjcarroll committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    2d375e3 View commit details
    Browse the repository at this point in the history