Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/witherable instances #504

Merged
merged 5 commits into from
Jun 27, 2018
Merged

Feature/witherable instances #504

merged 5 commits into from
Jun 27, 2018

Conversation

raveclassic
Copy link
Collaborator

@raveclassic raveclassic commented Jun 27, 2018 •
edited
Loading

Part of #485
Adds:

  • Witherable instance for Arrray
  • Witherable instance for Option
  • Witherable instance for StrMap
  • Witherable instance for Either (getWitherable using Monoid)
  • Witherable instance for Validation (getWitherable using Monoid)
  • tests

@raveclassic raveclassic requested a review from gcanti June 27, 2018 11:21
@raveclassic raveclassic merged commit 95b099c into master Jun 27, 2018
@raveclassic raveclassic deleted the feature/witherable-instances branch June 27, 2018 11:48
@gcanti
Copy link
Owner

gcanti commented Jun 27, 2018

You did a great job @raveclassic, thanks a lot!

@gcanti gcanti added this to the 1.7.0 milestone Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gcanti gcanti gcanti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@raveclassic @gcanti