Fixing the babel, scrypt, and base58 issues #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Nov 6, 2018
Closed
Closed
|
Thanks very much for working this out @bwhitn. Apologies for the time it has taken to respond on our end, I've been preoccupied elsewhere. Hopefully we can sort out something to prevent this happening again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix a few issues:
Static file loading issues: #388, #395, #393 (I also am not experiencing a #402 CharEnc issue with this build but I am not sure if this is a fix for this issue)
Scrypt using string for salt: #401
Base58 converting \x00 at begining and ending incorrectly: #380