Update disassembler library #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnLaTwC
reviewed
Mar 10, 2019
|
|
||
| var n = Math.min( 0x100000000, Math.pow( 2, 4 << ( S + 1 ) ) ); | ||
|
|
||
| //Sing bit adjust. |
|
Thanks very much for pointing this out @JohnLaTwC, and thanks to @artemisbot for updating the library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to disassembler to fix jump addresses (issue from upstream). Also added license information and author accreditation.
Thanks to @JohnLaTwC for flagging this up on Twitter.
Addtionally, at some point we should update this operation to use something like zydis with WASM but I'll have to do more research before I commit to doing that. 😛