Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope: Define GETTEXT_PACKAGE macro for recent cppcheck versions #1264

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

eht16
Copy link
Member

@eht16 eht16 commented Aug 1, 2023

Without this, cppcheck will throw errors like

store/scptreestore.c:1990:37: warning: syntax error [syntaxError]
  g_param_spec_boolean("sublevels", P_("Sublevels"),

This is probably caused by the P_() macro if GETTEXT_PACKAGE is not set.

Admittedly, this is the easy way to fix or better workaround it. But I guess this is OK. Otherwise, make a better PR :).

The new cppcheck error breaks the night builds on Debian Unstable (https://www.geany.org/download/nightly-builds/).

Without this, cppcheck will throw errors like
store/scptreestore.c:1990:37: warning: syntax error [syntaxError]
  g_param_spec_boolean("sublevels", P_("Sublevels"),

This is probably caused by the P_() macro if GETTEXT_PACKAGE is not set.
@eht16 eht16 added plugin/scope build system Automake build system issues labels Aug 1, 2023
@eht16 eht16 added this to the 1.39.0/2.0.0 milestone Aug 5, 2023
@eht16 eht16 merged commit fc1fcf3 into geany:master Sep 17, 2023
2 checks passed
@eht16 eht16 deleted the scope_fix_cppcgeck_warning branch September 17, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Automake build system issues plugin/scope
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant