Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spellcheck: Update style mappings #1277

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

eht16
Copy link
Member

@eht16 eht16 commented Oct 11, 2023

Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of new Scintilla API.

Is this OK?

At least the SpellCheck plugin needs a recent version of Geany and it is
probably good to require a recent version anyway.
@eht16 eht16 force-pushed the spellecheck_update_style_mappings branch from 382a08e to 362419a Compare October 11, 2023 15:11
@b4n
Copy link
Member

b4n commented Oct 13, 2023

Implicitly require Geany 2.0 for G-P as the SpellCheck plugin makes uses of new Scintilla API.

Is this OK?

It is, especially as I just merged #1281 which also uses newer API 😄

[edit] although in #1281 if we wanted we could make it conditional, it's easy enough to #ifdef SCI_SETCHANGEHISTORY

@eht16
Copy link
Member Author

eht16 commented Oct 14, 2023

Yesterday I noticed that the GeanyLua plugin also uses Scintilla 5.x API and so the version requirement bump is more than justified I think.
Adding conditionals in mutiple plugins only for a hypothetical backwards compability seems not very reasonable.

@eht16 eht16 merged commit c0aebc9 into geany:master Oct 16, 2023
1 of 2 checks passed
@eht16 eht16 deleted the spellecheck_update_style_mappings branch October 16, 2023 11:23
@eht16 eht16 changed the title Spellecheck: Update style mappings Spellcheck: Update style mappings Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants