Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect explicit source: option on gem entries #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewd
Copy link
Member

Previously we were collecting them as valid sources in general, but were not enforcing that those particular gems may only come from the stated catalog.

This particular behaviour was an oversight, but more generally, now that newer Bundler is comfortable with multiple separate GEM blocks for multiple catalog sources, we should probably also move that direction. My memory claims I got part way down that path earlier, before deciding we had to follow Bundler's squish-everything-together precedent... but I don't recall whether that involved actual recoverable code, or just some conceptual choices during implementation.

Previously we were collecting them as valid sources in general, but were
not enforcing that those particular gems may _only_ come from the stated
catalog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant