Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inadequate geological map from gp.plot_2d(geo_model, section_names = ["topography"]) #688

Closed
mkondratyev85 opened this issue Apr 6, 2022 · 2 comments

Comments

@mkondratyev85
Copy link
Contributor

mkondratyev85 commented Apr 6, 2022

If you add topography to geo_model in gempy then you can generate nicely looking geological map by using gempy function
plot_2d.

This process is described in details in the gempy manual:
https://docs.gempy.org/tutorials/ch1_fundamentals/ch1_3b_cross_sections.html#sphx-glr-tutorials-ch1-fundamentals-ch1-3b-cross-sections-py

However, there is s a subtle error in the process of constructing of the resulting map. This error is so subtle it's even made its way into the manual mentioned above.

sphx_glr_ch1_3b_cross_sections_004 png

Section 1 looks nice.

But If you look closer on section 2 on the resulting map from the manual you'll see that geology that is presented on the section differs from the geology under the trace of section 2 on the map. The same issue with section 3.

The problem here lies not in the section but in how this geological map is compiled. It's relief is drawn correctly. It's data points are placed on the correct positions. But the lithology and contacts are flipped along diagonal axis. That's why section1 looks correct.

mkondratyev85 added a commit to mkondratyev85/gempy that referenced this issue Apr 6, 2022
mkondratyev85 added a commit to mkondratyev85/gempy that referenced this issue Apr 6, 2022
@mkondratyev85 mkondratyev85 changed the title Inadequate geological from map gp.plot_2d(geo_model, section_names = ["topography"]) Inadequate geological map from gp.plot_2d(geo_model, section_names = ["topography"]) Apr 6, 2022
@Japhiolite
Copy link
Collaborator

Thanks for noticing and implementing a change @mkondratyev85 👍
I'll have a look at the PR

Japhiolite added a commit that referenced this issue Apr 29, 2022
Fixes issue #688 with slightly inadequate geological map as a result of plot_2d()
@Japhiolite
Copy link
Collaborator

PR is merged. Thanks again @mkondratyev85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants