Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update visualization_3d.py #602

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

RichardScottOZ
Copy link
Contributor

Visualize

Description

Please include a summary of the changes.

Relates to

Checklist

  • My code follows the PEP 8 style guidelines.
  • My code uses type hinting for function and method arguments and return values.
  • My code contains descriptive and helpful docstrings
    which are formatted per the Google Python Style Guidelines.
  • I have created tests which entirely cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New and existing tests pass locally with my changes.

This class is used to create points where to
evaluate the geological model. This class serves a container which transmit the XYZ coordinates to the
interpolator. There are several type of grids objects will feed into the Grid class
This class is used to create points usede to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardScottOZ could you change your correction here please. I would then merge it! Thanks :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, ok!

Copy link
Contributor

@AlexanderJuestel AlexanderJuestel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RichardScottOZ just change this one error and then we are finally good to go :)

fix typo.
@AlexanderJuestel AlexanderJuestel changed the base branch from master to dev_alexj September 16, 2021 07:00
@AlexanderJuestel
Copy link
Contributor

Thanks for the changes, merging now

@AlexanderJuestel AlexanderJuestel merged commit 0bb35a9 into gempy-project:dev_alexj Sep 16, 2021
@AlexanderJuestel AlexanderJuestel mentioned this pull request Sep 16, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants