-
-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use aesara and pymc4 instead of theano and pymc3 #706
Conversation
…No clue if CI builds would work.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The checks were always failing at the installation step. Apparently with aesara 2.7.8 there'd been a change with setuptools (aesara-devs/aesara#1050). Out of curiosity, I temporary froze aesara to 2.7.7 just to see whether the checks pass. Seems...like there are all tests passing now 🎉 |
we should also do some benchmarks with a gpu to ensure things are still fast, can probably help with that |
@Japhiolite that bug in aesara was fixed a couple of weeks ago. I can perform some benchmarking tests if needed |
That would be great @AndrewAnnex I've talked to @Leguark about merging, and we thought that we publish the switch to aesara as gempy 2.3 |
Currently, the remaining failing tests are due to a (in the meantime fixed) deprecation in But I was wondering though....whether we just should move forward with this PR - as is - to Version 2.3 and work from there to mainly get the pandas fixes up to speed with the new major version...with pandas 2.0 apparently coming out within the next week. Thoughts? |
Agree with proceeding to get GemPy properly working again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newest arviz version ( v0.15.1 ) does not have a from_pymc3()
method anymore...in fact, I don't see a from_pymc()
method either....So I guess we'll have to see how to fix this as we go by.
closing as per #796 |
…No clue if CI builds would work. todo need to update the github worker to allow this branch to run.
likely there are a lot of api breaking changes I did not address here, I did not attempt to run it locally yet. Also the CI environment for gempy is a bit confusing (still using travis?). Likely these scripts could be cleaned up a bit more to make testing easier
Description
swap out all usage of theano for aesara and pymc3 for pymc4.
Relates to
#701
Checklist
which are formatted per the Google Python Style Guidelines.
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).