Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] surface points added to wrong surface #817

Merged
merged 1 commit into from
Aug 14, 2023
Merged

[BUG] surface points added to wrong surface #817

merged 1 commit into from
Aug 14, 2023

Conversation

Japhiolite
Copy link
Collaborator

Description

Manually added surface points with add_surface_points were allocated to the first created surface.
This was due to a type check solely for int. Changed to isinstance(idx, (int, np.int64)) as somewhere along the creation, idx gets changed from int to np.int64...

Relates to #813

Checklist

  • My code follows the PEP 8 style guidelines.
  • My code uses type hinting for function and method arguments and return values.
  • My code contains descriptive and helpful docstrings
    which are formatted per the Google Python Style Guidelines.
  • I have created tests which entirely cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New and existing tests pass locally with my changes.

@Japhiolite Japhiolite merged commit 9866d78 into main Aug 14, 2023
2 checks passed
@Japhiolite Japhiolite deleted the fix813 branch August 14, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant