Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Decidim to v0.27 #490

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

Upgrade Decidim to v0.27 #490

wants to merge 66 commits into from

Conversation

laurajaime
Copy link
Collaborator

@laurajaime laurajaime commented Jul 11, 2024 •
edited
Loading

🎩 What? Why?

Upgrade Decidim to v0.27

Release notes: https://github.com/CodiTramuntana/decidim/blob/release/0.27-stable/CHANGELOG.md

In this version, participatory processes has type. We have a custom module for that (decidim-type) but is not necessary anymore, so we remove the custom module.

FIXES

  • Add translation in upload file in private users in processes (The same has been done as for other uploads, for example, import process)
    Example in other modal
    Screenshot from 2024-09-12 14-04-41
    Fix
    image

TO-DO

  • Remove decidim-type and rework participatory processes

Related PRs:

📷 Screenshots (optional)

image

tramuntanal
tramuntanal reviewed Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tramuntanal
tramuntanal reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test? can we document exactly what are we changing from the original class?
Can we use a decorator instead of overriding the whole class?

...extended/app/serializers/decidim/participatory_processes/participatory_process_serializer.rb Outdated
Comment on lines 131 to 133
def url
Decidim::ResourceLocatorPresenter.new(process).url&.split("?")&.first
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you document why we need this? Process URLs don't have query parameters no?

...extended/app/serializers/decidim/participatory_processes/participatory_process_serializer.rb Outdated
Comment on lines 76 to 77
def short_description_ca
ActionController::Base.helpers.strip_tags(process.short_description["ca"])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove and take all translations instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tramuntanal tramuntanal tramuntanal requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurajaime @tramuntanal