Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing keywords from metadata, multiple DescriptiveKeywords not recognized [4.4.2] #7841

Closed
Bear-LB opened this issue Mar 5, 2024 · 2 comments · Fixed by #7843
Closed
Assignees
Milestone

Comments

@Bear-LB
Copy link
Collaborator

Bear-LB commented Mar 5, 2024

Describe the bug
Using Geonetwork 4.4.2
We harvested a bunch of metadata, and the keyword section of the metadata looks like this

<gmd:descriptiveKeywords>
	<gmd:MD_Keywords>
		<gmd:keyword>
			<gco:CharacterString>KEYWORD 1</gco:CharacterString>
		</gmd:keyword>
	</gmd:MD_Keywords>
</gmd:descriptiveKeywords>
<gmd:descriptiveKeywords>
	<gmd:MD_Keywords>
		<gmd:keyword>
			<gco:CharacterString>KEYWORD 2</gco:CharacterString>
		</gmd:keyword>
	</gmd:MD_Keywords>
</gmd:descriptiveKeywords>

This in turn means that on the searchpage, it's not possible to search for "KEYWORD 2"
only "KEYWORD 1" would be included.
Here's how it looks while looking at the metadata default view
image
This behaviour was not present in v3.2.X . Keywords were included from multiple DescriptiveKeywords sections in Version v3.2.X

A manual fix for us would be to change the keywords to be like this and then it would work.

<gmd:descriptiveKeywords>
	<gmd:MD_Keywords>
		<gmd:keyword>
			<gco:CharacterString>KEYWORD 1</gco:CharacterString>
		</gmd:keyword>
		<gmd:keyword>
			<gco:CharacterString>KEYWORD 2</gco:CharacterString>
		</gmd:keyword>
	</gmd:MD_Keywords>
</gmd:descriptiveKeywords>

But if we had to do this everytime we had to Harvest from upstream, that would be troublesome. Is there a way to fix this ?
Or Is it working as expected and it's our service providers job to fix their metadata ?

Thanks for your time

@Bear-LB Bear-LB changed the title Missing keywords from metadata, multiple DescriptiveKeywords not accepted [4.4.2] Missing keywords from metadata, multiple DescriptiveKeywords not recognized [4.4.2] Mar 5, 2024
@fxprunayre fxprunayre added this to the 4.4.3 milestone Mar 6, 2024
@fxprunayre fxprunayre self-assigned this Mar 6, 2024
fxprunayre added a commit that referenced this issue Mar 6, 2024
thesaurus block

Fixes #7841

Use the current-group which contains all grouped blocks.
Also fix record view which in this case was repeating keywords because
the `otherKeywords-` prefix was matching other thesaurus key eg
`otherKeywords-place`.
@fxprunayre
Copy link
Member

Can you check with #7843 ? Also it is not really recommended to encode keyword like this, it will make the editor form more complicated, it is better to group keywords by thesaurus - and those not part of a thesaurus together.

@Bear-LB
Copy link
Collaborator Author

Bear-LB commented Mar 6, 2024

Great it seems to work! Thanks alot for your fast response
Harvest results before your patch:

Harvest results after your patch

And way more keywords are showing up in search page.

fxprunayre added a commit that referenced this issue Mar 7, 2024
thesaurus block

Fixes #7841

Use the current-group which contains all grouped blocks.
Also fix record view which in this case was repeating keywords because
the `otherKeywords-` prefix was matching other thesaurus key eg
`otherKeywords-place`.
geonetworkbuild pushed a commit that referenced this issue May 30, 2024
thesaurus block

Fixes #7841

Use the current-group which contains all grouped blocks.
Also fix record view which in this case was repeating keywords because
the `otherKeywords-` prefix was matching other thesaurus key eg
`otherKeywords-place`.
josegar74 pushed a commit that referenced this issue May 30, 2024
)

thesaurus block

Fixes #7841

Use the current-group which contains all grouped blocks.
Also fix record view which in this case was repeating keywords because
the `otherKeywords-` prefix was matching other thesaurus key eg
`otherKeywords-place`.

Co-authored-by: Francois Prunayre <fx.prunayre@gmail.com>
josegar74 pushed a commit that referenced this issue Jun 4, 2024
)

thesaurus block

Fixes #7841

Use the current-group which contains all grouped blocks.
Also fix record view which in this case was repeating keywords because
the `otherKeywords-` prefix was matching other thesaurus key eg
`otherKeywords-place`.

Co-authored-by: Francois Prunayre <fx.prunayre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants