Refactor JsonDatabaseMigration to make easier to implement future JSON setting migrations #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a bug about the map's value types from `String` to `List` * Use interface `Map` instead of concrete class `LinkedHashMap` in `DatabaseMigration`. * Use try-with-resources statement where possible. * Reindent and organize imports
* This refactor make possible to implement a JsonDatabaseMigration only defining the setting name and the list of JSON fields to update/modify.
juanluisrp
changed the title
Delawen
approved these changes
Jun 5, 2018
fxprunayre
added a commit
to fxprunayre/core-geonetwork
that referenced
this pull request
Dec 18, 2018
The ui/config settings introduced geonetwork#1848 (and inspired from Sextant) is somehow a bit hard to maintain. The default value is now set from CatController only. The default db value is empty to use the one from CatController until a db value is defined by the catalogue admin. JsonDatabaseMigration task should be used to update the settings (see geonetwork#2808). We should not set the full value in SQL migration script anymore (BTW this is a line in conflict in most of the PR since then). JSON editor is now used instead of the textarea. Future work required? Maybe we should find a better way to merge the db value and update with the latest.
fxprunayre
added a commit
that referenced
this pull request
Dec 20, 2018
* UI configuration improvement. The ui/config settings introduced #1848 (and inspired from Sextant) is somehow a bit hard to maintain. The default value is now set from CatController only. The default db value is empty to use the one from CatController until a db value is defined by the catalogue admin. JsonDatabaseMigration task should be used to update the settings (see #2808). We should not set the full value in SQL migration script anymore (BTW this is a line in conflict in most of the PR since then). JSON editor is now used instead of the textarea.
pvgenuchten
pushed a commit
to pvgenuchten/core-geonetwork
that referenced
this pull request
Mar 17, 2021
* UI configuration improvement. The ui/config settings introduced geonetwork#1848 (and inspired from Sextant) is somehow a bit hard to maintain. The default value is now set from CatController only. The default db value is empty to use the one from CatController until a db value is defined by the catalogue admin. JsonDatabaseMigration task should be used to update the settings (see geonetwork#2808). We should not set the full value in SQL migration script anymore (BTW this is a line in conflict in most of the PR since then). JSON editor is now used instead of the textarea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this refactor the only things needed to implement a
JsonDatabaseMigrationis to define the setting name to update and the list of JSON paths to update/modify in the methodsetUpNewSettingValues.This PR also moves
AdvancedSearchFormMigrationto version v3.4.3 since the PR #2547 was not included in v3.4.2 release.Another fix in this PR is to use the right types for map values in
database-migration.xml.