Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata workflow: update edit button to use in the link the metadata identifier of the working copy when a metadata has a working copy #6321

Merged
merged 3 commits into from
May 19, 2022
Merged

Metadata workflow: update edit button to use in the link the metadata identifier of the working copy when a metadata has a working copy #6321

merged 3 commits into from
May 19, 2022

Conversation

josegar74
Copy link
Member

The backend code always edits the working copy (independently of receiving the identifier of the approved or working copy), but the UI stores the information of the approved version and causes the following error:

angular.js?v=0340653132a9d5190768df9193cb149c80f92e7e:14199 SyntaxError: Unexpected token u in JSON at position 0
    at JSON.parse (<anonymous>)
    at Object.onFormLoad (EditorService.js:415:37)
    at refreshForm (EditorService.js:319:24)
    at Object.refreshEditorForm (EditorService.js:331:16)
    at EditorService.js:163:22
    at angular.js?v=0340653132a9d5190768df9193cb149c80f92e7e:11728:13
    at processQueue (angular.js?v=0340653132a9d5190768df9193cb149c80f92e7e:16696:28)
    at angular.js?v=0340653132a9d5190768df9193cb149c80f92e7e:16712:27
    at Scope.$eval (angular.js?v=0340653132a9d5190768df9193cb149c80f92e7e:17994:28)

This has been identified to fail only in main branch, but requires to be check if required also for 3.12.x

@josegar74 josegar74 added this to the 4.2.0 milestone May 18, 2022
@josegar74 josegar74 requested a review from fxprunayre May 18, 2022 15:09
@josegar74
Update edit button to use the working copy metadata identifier when a…
dbcd003 
… metadata has a working copy - refactor
@josegar74
Fix the metadata detail page code to display the non-draft version wh…
381283f 
…en the results include the approved and the working copy (draft) versions, and it is requested the non-draft version
@josegar74 josegar74 mentioned this pull request May 19, 2022
Merged
@fxprunayre fxprunayre merged commit 90c25b6 into geonetwork:main May 19, 2022
@juanluisrp juanluisrp mentioned this pull request Jun 8, 2022
Closed
fxprunayre added a commit that referenced this pull request May 13, 2024
@fxprunayre
Workflow / Edit action / Fix link in search results
b8f99b3 
Follow up of #6321

This was noticed because then when an approved record is found, the edit
action in the search result page was opening the editor with a link
http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

Then the editor was opening the editor form with the UUID.

And in such case the editor does not do the redirection (in
MetadataEditingApi.java#L153).
@fxprunayre fxprunayre mentioned this pull request May 13, 2024
Merged
10 tasks
josegar74 pushed a commit that referenced this pull request May 16, 2024
@fxprunayre
Workflow / Edit action / Fix link in search results (#8031)
9e4b7ec 
Follow up of #6321

This was noticed because then when an approved record is found, the edit
action in the search result page was opening the editor with a link
http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

Then the editor was opening the editor form with the UUID.

And in such case the editor does not do the redirection (in
MetadataEditingApi.java#L153).
geonetworkbuild pushed a commit that referenced this pull request May 16, 2024
@fxprunayre @github-actions
Workflow / Edit action / Fix link in search results
2c23ab8 
Follow up of #6321

This was noticed because then when an approved record is found, the edit
action in the search result page was opening the editor with a link
http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

Then the editor was opening the editor form with the UUID.

And in such case the editor does not do the redirection (in
MetadataEditingApi.java#L153).
josegar74 pushed a commit that referenced this pull request May 16, 2024
@geonetworkbuild @fxprunayre
Workflow / Edit action / Fix link in search results (#8054)
1e42fd7 
Follow up of #6321

This was noticed because then when an approved record is found, the edit
action in the search result page was opening the editor with a link
http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

Then the editor was opening the editor form with the UUID.

And in such case the editor does not do the redirection (in
MetadataEditingApi.java#L153).

Co-authored-by: Francois Prunayre <fx.prunayre@gmail.com>
joachimnielandt pushed a commit to Informatievlaanderen/metadata-geonetwork that referenced this pull request May 28, 2024
@fxprunayre
Workflow / Edit action / Fix link in search results
17cd31e 
Follow up of geonetwork#6321

This was noticed because then when an approved record is found, the edit
action in the search result page was opening the editor with a link
http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

Then the editor was opening the editor form with the UUID.

And in such case the editor does not do the redirection (in
MetadataEditingApi.java#L153).
joachimnielandt pushed a commit to Informatievlaanderen/metadata-geonetwork that referenced this pull request May 28, 2024
Merged PR 35546: Workflow / Edit action / Fix link in search results
041ecfb 
    Follow up of geonetwork#6321

    This was noticed because then when an approved record is found, the edit
    action in the search result page was opening the editor with a link
    http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

    Then the editor was opening the editor form with the UUID.

    And in such case the editor does not do the redirection (in
    MetadataEditingApi.java#L153).

GN ref geonetwork#8031

Related work items: #189418
fxprunayre added a commit to SPW-DIG/metawal-core-geonetwork that referenced this pull request Jul 18, 2024
@fxprunayre
Workflow / Edit action / Fix link in search results (geonetwork#8031)
20e0090 
Follow up of geonetwork#6321

This was noticed because then when an approved record is found, the edit
action in the search result page was opening the editor with a link
http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

Then the editor was opening the editor form with the UUID.

And in such case the editor does not do the redirection (in
MetadataEditingApi.java#L153).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxprunayre fxprunayre fxprunayre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@josegar74 @fxprunayre