Fix microservices proxy detection #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of geonetwork#7094. The targetUri property can be configured using multiple methods, not only as init parameter in web.xml servlet's config but also as environment variable, system property or config.properties entry. This change saves the targetUri value in a ServletContext attribute so it can be retrieved from other servlets to check its value. Changed the value of <load-on-startup> servlet property to init the attribute on server start.
fxprunayre
approved these changes
May 25, 2023
josegar74
reviewed
May 25, 2023
There was a problem hiding this comment.
Tested the different scenarios and works fine:
-
Environment variable:
export GEONETWORK_MICROSERVICESPROXY_TARGETURI=http://localhost:9901 -
JVM parameter:
-Dgeonetwork.MicroServicesProxy.targetUri=http://localhost:9901 -
config.properties:geonetwork.MicroServicesProxy.targetUri=http://localhost:9901 -
Update
pom.xml:<microservices.url>http://localhost:9901</microservices.url>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #7094.
The targetUri property can be configured using multiple methods, not only as init parameter in
web.xmlservlet's config but also as environment variable, system property orconfig.propertiesentry. This change saves the targetUri value in aServletContextattribute so it can be retrieved from other servlets to check its value. Added<load-on-startup>servlet property to init the attribute on server start.