Indexing / Do not create empty object if no text #7294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a CharacterString or an Anchor is empty, an empty object is created in the index. This is not necessary.
eg.
```xml
<gmd:identificationInfo>
<gmd:MD_DataIdentification>
<gmd:citation>
<gmd:CI_Citation>
<gmd:title>
<gco:CharacterString>Biologische Waarderingskaart en Natura 2000 Habitat</gco:CharacterString>
</gmd:title>
<gmd:alternateTitle gco:nilReason="missing">
<gco:CharacterString/>
</gmd:alternateTitle>
```
|
Kudos, SonarCloud Quality Gate passed!
|
CMath04
approved these changes
Sep 20, 2023
fxprunayre
added a commit
that referenced
this pull request
Sep 21, 2023
Follow #7294 Clarify usage of the function which can return an element or text.
josegar74
pushed a commit
that referenced
this pull request
Sep 21, 2023
Follow #7294 Clarify usage of the function which can return an element or text.
josegar74
pushed a commit
that referenced
this pull request
Sep 21, 2023
When a CharacterString or an Anchor is empty, an empty object is created in the index. This is not necessary.
eg.
```xml
<gmd:identificationInfo>
<gmd:MD_DataIdentification>
<gmd:citation>
<gmd:CI_Citation>
<gmd:title>
<gco:CharacterString>Biologische Waarderingskaart en Natura 2000 Habitat</gco:CharacterString>
</gmd:title>
<gmd:alternateTitle gco:nilReason="missing">
<gco:CharacterString/>
</gmd:alternateTitle>
```
josegar74
pushed a commit
that referenced
this pull request
Sep 21, 2023
Follow #7294 Clarify usage of the function which can return an element or text.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a CharacterString or an Anchor is empty, an empty object is created in the index. This is not necessary.
eg.
Index change:
This would avoid field label to be displayed with no value eg.
