Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release / Utility script #7399

Closed
wants to merge 7 commits into from
Closed

Release / Utility script #7399

wants to merge 7 commits into from

Conversation

fxprunayre
Copy link
Member

No description provided.

@fxprunayre fxprunayre added this to the 4.4.1 milestone Oct 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

ianwallen
ianwallen reviewed Oct 5, 2023
View reviewed changes
release-build.sh Outdated Show resolved Hide resolved
@fxprunayre fxprunayre modified the milestones: 4.4.1, 4.4.2 Nov 22, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@fxprunayre fxprunayre modified the milestones: 4.4.2, 4.4.3 Jan 23, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fxprunayre fxprunayre mentioned this pull request Feb 1, 2024
Merged
10 tasks
@fxprunayre fxprunayre modified the milestones: 4.4.3, 4.4.4 Mar 13, 2024
@fxprunayre
Copy link
Member Author

fxprunayre commented Mar 14, 2024 •
edited
Loading

Testing it for 4.4.3. Some improvements that we can add:

  • check all required apps for building are present
    • Java check
    • git check
    • maven check
    • ant check
    • xmlstarlet check
  • add a no clone option (to build current branch)
  • get version from the pom (instead of providing arguments ?)
  • test on mac
  • test on non main branch
  • remove arguments from publish script

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fxprunayre fxprunayre marked this pull request as ready for review March 19, 2024 08:40
@fxprunayre fxprunayre modified the milestones: 4.4.4, 4.4.5 Apr 16, 2024
@jodygarnett
Copy link
Contributor

Thanks for script, I will test and provide feedback.

  • Move to a "build" folder? As I expect we will have more scripts over time ...

@fxprunayre
Copy link
Member Author

Thanks for script, I will test and provide feedback.

👍

  • Move to a "build" folder? As I expect we will have more scripts over time ...

We already have couple of scripts in the root - maybe good to have all in the same place ?

image

Then we also have https://github.com/geonetwork/core-geonetwork/blob/main/web-ui/download-from-transifex.sh which is quite specific to the web-ui module.

jodygarnett added a commit that referenced this pull request Apr 16, 2024
@jodygarnett
Document use of release scripts ahead of 4.4.4 release
330c079 
These release scripts are from #7399

Thanks @fxprunayre for this improvement.
@jodygarnett
Copy link
Contributor

Thanks, used your scripts today for the 4.4.4 release. Had to break them up into multiple steps in order to review change note and test before publishing etc...

See docs at https://docs.geonetwork-opensource.org/latest/contributing/doing-a-release/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianwallen ianwallen ianwallen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@fxprunayre @jodygarnett @ianwallen