Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor / Distribution improvements #7468

Merged
merged 42 commits into from
Jan 30, 2024
Merged

Conversation

josegar74
Copy link
Member

@josegar74 josegar74 commented Nov 3, 2023

Current editor interface allows to add 2 type of links:

  • online resources (eg. URL, file uploaded in the datastore, WMS, …)
  • metadata records (eg. source dataset, collection)

In view mode, links are displayed:

  • for online resources grouped by type (ie. API, download, legend, …)
  • for metadata records with cards or list layout

This proposal moves linking to online resources to a dedicated block in the editor using the same categorization as in view mode.

Details

  • Between the overview panel and associated resources panel, a distribution panel is added

image

  • The distribution panel is configurable in the config-editor.xml with a default configuration
  • Each distribution types can have customized add buttons to open the add link popup with a specific type

image

  • The add link popup allows to easily add file to the filestore and set the URL at the same time

image

  • For each type of links, field label can be customized

image

  • Specific link widget are preserved (ie. DOI management and WFS feature harvesting)
  • Suggestions can now be added next to the link they apply to.

image

  • Add OGC API link types

Technical info

  • The distribution panel can also be used in the main form
  • The same directive is used in view and edit mode

Future improvements

  • Use the index document link object in the editing popup (instead of the Related API model)

Checklist

  • I have read the [contribution guidelines](https://github.com/geonetwork/core-geonetwork/blob/main/CONTRIBUTING.md
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests)
  • User documentation provided for new features or enhancements in mannual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Ifremer

josegar74 and others added 30 commits October 17, 2023 17:39
…f we move more URL validation logic in a service and if we simplify the layout to a simple green/orange/red icon + message.
…record view also. Improved conversion of metadata links to the format required by the online resources dialog
…us type of links. The type is used to find the proper process to use.
… well as in the side column.

Add an icon before the link
Copy link

sonarcloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fxprunayre fxprunayre modified the milestones: 4.4.2, 4.4.3 Jan 18, 2024
@fxprunayre fxprunayre added schema plugin change Indicate that this work introduces a schema plugin change. changelog labels Jan 30, 2024
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@fxprunayre fxprunayre merged commit df6a770 into main Jan 30, 2024
11 checks passed
@fxprunayre fxprunayre deleted the 44-metadataeditor-distributions branch February 9, 2024 09:12
josegar74 added a commit to GeoCat/core-geonetwork that referenced this pull request Mar 5, 2024
…9 distributions as protocols are not categorized as ISO19115-3 protocols.

Follow up of geonetwork#7468
josegar74 added a commit to GeoCat/core-geonetwork that referenced this pull request Mar 5, 2024
…9 distributions as protocols are not categorized as ISO19115-3 protocols.

Follow up of geonetwork#7468
josegar74 added a commit that referenced this pull request Mar 5, 2024
…9 distributions as protocols are not categorized as ISO19115-3 protocols. (#7838)

* Editor / Distribution improvements - Update configuration for ISO19139 distributions as protocols are not categorized as ISO19115-3 protocols.
Follow up of #7468

* Fix download protocol value in iso19115-3.2018 editor configuration
fxprunayre added a commit that referenced this pull request Mar 6, 2024
Follow up of #7468

Refresh list when user remove the last link of a record. In that case md.link is undefined and we need to reload distributions.
josegar74 pushed a commit that referenced this pull request Mar 7, 2024
Follow up of #7468

Refresh list when user remove the last link of a record. In that case md.link is undefined and we need to reload distributions.
joachimnielandt pushed a commit to Informatievlaanderen/metadata-geonetwork that referenced this pull request May 28, 2024
Also requires https://agiv.visualstudio.com/Metadata/_git/MetadataDcatAp/pullrequest/33239

Also contains 2 main editor UI changes :
* geonetwork#7468
* geonetwork#7669 (not yet merged)
but those changes will only be visible in advanced view.

Not that many conflicts. Main migration required was in DCAT and XslUtil in getRecordResourceURI. Tested in DCAT record
https://metadata.vlaanderen.be/srv/dut/catalog.search#/metadata/a5920c90-fc85-3e15-851a-61dd3eec85b8 which properly links.

Related work items: #190764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog schema plugin change Indicate that this work introduces a schema plugin change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants