Datahub: Display HTML code for chart web component #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
…ermalink and data-view-web-component together displays both components in tabs based on web_component_embedder_url setting for data-view-permalink
|
GitHub Pages links:
|
jahow
reviewed
Jun 16, 2023
libs/feature/record/src/lib/data-view-share/data-view-share.component.html
Outdated
Show resolved
Hide resolved
libs/feature/record/src/lib/data-view-web-component/data-view-web-component.component.spec.ts
Outdated
Show resolved
Hide resolved
libs/ui/inputs/src/lib/copy-text-button/copy-text-button.component.html
Outdated
Show resolved
Hide resolved
tkohr
force-pushed
the
data-view-web-component
branch
from
348e7b3
to
2bde180
Compare
|
Thanks for your feedback @jahow ! I've addressed your comments in the latest commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR displays the web component HTML of the currently displayed chart.
To-do:
data-view-permalinkanddata-view-web-componentinto one component, including the tabs currently inrecord-metadatathat only displays ifweb_component_embedder_urlsetting is set. Or add one intermediate component which only handles the tabs and the display condition (web_component_embedder_url).