Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub / make hyperlinks clickable in "lineage" and "usage conditions" #571

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Aug 10, 2023

Issue

In dataset view, in the "lineage" and "usages" sections, the text may contain hyperlinks, that weren't clickable nor displayed as such.

Resolution

Created a directive that dynamically creates an hyperlink object and an icon for any detected link in the text.

To test

Go to dataset/a8b5e6c0-c21d-4c32-b8f9-10830215890a, which has a link in its "usage" section.
Go to dataset/ee965118-2416-4d48-b07e-bbc696f002c2 which has a link in its "lineage" section.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@cmoinier cmoinier force-pushed the GSGCT-55-hyperlinks-clickable branch from c22c384 to 3a98dcf Compare August 10, 2023 09:53
@coveralls
Copy link

coveralls commented Aug 10, 2023

Coverage Status

coverage: 86.869% (-1.5%) from 88.387% when pulling 91f857e on GSGCT-55-hyperlinks-clickable into 3c19b2d on main.

@jahow jahow changed the title GSGCT-55 : Make hyperlinks clickable Datahub / make hyperlinks clickable in "lineage" and "usage conditions" Aug 14, 2023
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution, it works great in my tests. I've made a few comments which are important IMO. One thing that would also be very beneficial is if you could add a story to the directive, so that it shows up in Storybook. Otherwise it is quite hard to really figure out what results it gives without launching an actual backend.

Great work 👍 thanks!

As an aside, I noted than when the abstract contains links, they will not be processed. This is "expected" as we assume the abstract to be HTML, but... I think we'll have to use the linkify directive there as well at some point. But this is for another time.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work :)

@cmoinier cmoinier force-pushed the GSGCT-55-hyperlinks-clickable branch from 3a98dcf to 2f73f58 Compare August 22, 2023 12:35
@cmoinier cmoinier merged commit 483590d into main Aug 22, 2023
7 checks passed
@jahow jahow deleted the GSGCT-55-hyperlinks-clickable branch August 22, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants