-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datahub / make hyperlinks clickable in "lineage" and "usage conditions" #571
Conversation
Affected libs:
|
c22c384
to
3a98dcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution, it works great in my tests. I've made a few comments which are important IMO. One thing that would also be very beneficial is if you could add a story to the directive, so that it shows up in Storybook. Otherwise it is quite hard to really figure out what results it gives without launching an actual backend.
Great work 👍 thanks!
As an aside, I noted than when the abstract contains links, they will not be processed. This is "expected" as we assume the abstract to be HTML, but... I think we'll have to use the linkify directive there as well at some point. But this is for another time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work :)
3a98dcf
to
2f73f58
Compare
Issue
In dataset view, in the "lineage" and "usages" sections, the text may contain hyperlinks, that weren't clickable nor displayed as such.
Resolution
Created a directive that dynamically creates an hyperlink object and an icon for any detected link in the text.
To test
Go to
dataset/a8b5e6c0-c21d-4c32-b8f9-10830215890a
, which has a link in its "usage" section.Go to
dataset/ee965118-2416-4d48-b07e-bbc696f002c2
which has a link in its "lineage" section.