[editor] Change URL query for pagination #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs:
|
fgravin
changed the title
cmoinier
force-pushed
the
ME/pagination-url
branch
from
1561f63
to
59d9c16
Compare
jahow
reviewed
Sep 7, 2023
There was a problem hiding this comment.
Thanks, the test fails because apparently there's an undefined alias in there, that looks unintentional I think? Anyways the structure is good 🙂 We have the issue now that the local docker composition contains less than 15 datasets and so there is only one page available, but this will change soon I think so we can leave the test like that.
cmoinier
force-pushed
the
ME/pagination-url
branch
from
59d9c16
to
a40ff61
Compare
|
Thanks for the review. It should be working now (with enough records) ! |
jahow
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current page should appear in the current route as a query param like "&page=X"
Resolution
Most changes were adressed in #605 , e2e test is added here.
To test
Go to
/records/allin metadata-editor app and switch pages around.