-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[editor]: Add formats to table #609
Conversation
Affected libs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking quite good and simple, thanks! The formats computation might have a little bit of an unnecessary overhead in its current form, see my comments below.
libs/ui/search/src/lib/record-table/record-table.component.html
Outdated
Show resolved
Hide resolved
libs/ui/search/src/lib/record-table/record-table.component.html
Outdated
Show resolved
Hide resolved
libs/ui/search/src/lib/record-table/record-table.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a commit that fixes the format order (it was upside down), and adjusted the badge size a little bit to make them more consistent:
Thanks for all the work on this @Angi-Kinas!!
This PR adds the formats with its corresponding color badges to the table and sorts them by priority. On hover over the number you can see the remaining formats.
TODO: