Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[editor]: Add formats to table #609

Merged
merged 6 commits into from
Sep 8, 2023
Merged

[editor]: Add formats to table #609

merged 6 commits into from
Sep 8, 2023

Conversation

Angi-Kinas
Copy link
Collaborator

@Angi-Kinas Angi-Kinas commented Sep 6, 2023

This PR adds the formats with its corresponding color badges to the table and sorts them by priority. On hover over the number you can see the remaining formats.

image

TODO:

  • Styling for colum (make badges same size)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Affected libs: feature-record, feature-router, ui-search, feature-search, feature-map, feature-dataviz, util-shared, ui-elements, feature-catalog, ui-catalog, ui-widgets, feature-editor, ui-inputs,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking quite good and simple, thanks! The formats computation might have a little bit of an unnecessary overhead in its current form, see my comments below.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a commit that fixes the format order (it was upside down), and adjusted the badge size a little bit to make them more consistent:
image

Thanks for all the work on this @Angi-Kinas!!

@jahow jahow merged commit f07dda8 into main Sep 8, 2023
5 checks passed
@jahow jahow deleted the add-format-to-table branch September 8, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants