Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(favorites): do not crash search if favorites cannot be fetched #630

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Sep 22, 2023

The search will still work but favorite records will not appear as such. The error received when fetching the favorites will be printed to the console instead.

Fixes #626

The search will still work but favorite records will not appear as such
@github-actions
Copy link
Contributor

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 85.964% (+0.05%) from 85.915% when pulling f50fc43 on handle-favorite-api-error into a9fd646 on main.

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good !

@jahow jahow merged commit 646215e into main Sep 22, 2023
7 checks passed
@jahow jahow deleted the handle-favorite-api-error branch October 19, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datahub: no result if userSelection API returns an error
3 participants