Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datahub: Hide nav menu on scroll down #631

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Datahub: Hide nav menu on scroll down #631

merged 2 commits into from
Sep 22, 2023

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Sep 22, 2023 •
edited
Loading

Small fix to hide nav menu completely and make its buttons unclickable when scrolling down.

@tkohr
fix(header): put nav menu into wrapper
3928c7f 
this hides it completely and makes its buttons unclickable
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023 •
edited
Loading

Affected libs: ``,
Affected apps: datahub,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 85.915%. remained the same when pulling 3928c7f on nav-menu-hide into a9fd646 on main.

jahow
jahow approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that works flawlessly!!

@tkohr tkohr merged commit 6733dec into main Sep 22, 2023
7 checks passed
@tkohr tkohr deleted the nav-menu-hide branch September 22, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkohr @coveralls @jahow