Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: Fix display of usage conditions #634

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Datahub: Fix display of usage conditions #634

merged 3 commits into from
Sep 25, 2023

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Sep 25, 2023

PR fixes a case where message that there are no usage conditions, was not displayed and wraps URLs in "Details" correctly.

usage

@github-actions
Copy link
Contributor

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 86.264% (+0.05%) from 86.219% when pulling dbfc328 on fix-usage-conditions into 1083b93 on main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks!

@tkohr tkohr merged commit 4264734 into main Sep 25, 2023
7 checks passed
@tkohr tkohr deleted the fix-usage-conditions branch September 25, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants