Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix favorite star tooltip translation #653

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix favorite star tooltip translation #653

merged 1 commit into from
Oct 19, 2023

Conversation

fgravin
Copy link
Member

@fgravin fgravin commented Oct 18, 2023

Ensure that the translation is loaded when the tooltip is created.
The i18n service loader is aynch, keep that in mind.

don't use translateService.instant on component property declarations
@github-actions
Copy link
Contributor

Affected libs: feature-search, feature-router, feature-record, feature-map, feature-dataviz,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@fgravin fgravin added the bug Something isn't working label Oct 19, 2023
@fgravin fgravin added this to the 2.0.1 milestone Oct 19, 2023
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, indeed using .instant() should be avoided as much as possible!

@fgravin fgravin merged commit 4c3057d into main Oct 19, 2023
7 checks passed
@fgravin fgravin deleted the fix-i18n-metadata branch October 19, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants