Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E tests to workflow #657

Merged
merged 5 commits into from
Nov 15, 2023
Merged

Add E2E tests to workflow #657

merged 5 commits into from
Nov 15, 2023

Conversation

f-necas
Copy link
Collaborator

@f-necas f-necas commented Oct 20, 2023

🔧 E2E tests now works with Github actions.

⚠️ The default dump has been modified

  • New group with a logo in Geonetwork : Barbie Inc.
  • A record has been modified to get this group as organization.

💢 Known problems

  • Tests who access to Geonetwork (login/editing parameters) takes a lot of time (~15/20 sec).

@f-necas f-necas requested a review from jahow October 20, 2023 09:40
@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2023

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, common-domain, api-metadata-converter, feature-editor, ui-search, common-fixtures, util-shared, ui-elements, ui-catalog, ui-widgets, ui-inputs, ui-map, ui-dataviz, util-app-config,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, map-viewer, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for tackling this! that must have been a lot of work. Having e2e tests running on the CI will add more constraints but hopefully it will help us keep a higher level of quality. 😎

I think it might be good to add a npm run e2e script (if it's not already there) and mention that having it pass is mandatory in the contributing guidelines.

Other than that I had several questions on your changes, see below!

support-services/docker-entrypoint-initdb.d/dump Outdated Show resolved Hide resolved
conf/default.toml Outdated Show resolved Hide resolved
$cookie.find('button').eq(0).click()
cy.scrollTo('top')
}
Cypress.on('uncaught:exception', (err) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping we could have a central place to put Cypress custom commands, instead of having to duplicate these in the different apps; or maybe from here you could import the commands from the datahub-e2e app?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find a simple and clean way for the moment so I didn't implement it by now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be done later, no worries

apps/metadata-editor-e2e/src/e2e/dashboard.cy.ts Outdated Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
apps/metadata-editor-e2e/src/e2e/my-org.cy.ts Show resolved Hide resolved
@f-necas f-necas merged commit eb6728e into develop Nov 15, 2023
7 of 8 checks passed
@jahow jahow deleted the CI/e2e branch January 11, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants