Fix gravatar service calls #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the subscription in the constructor which is error prone, improve the service so it returns observables
|
Affected libs:
|
detected via e2e tests
fgravin
commented
Dec 7, 2023
| @@ -12,7 +12,7 @@ export class GravatarService implements AvatarServiceInterface { | |||
| private GRAVATAR_IDENTICON = 'mp' | |||
|
|
|||
| private readonly identicon$ = this.gn4SettingsService.identicon$.pipe( | |||
| map((identicon) => identicon.replace('gravatar:', '')) | |||
| map((identicon) => identicon?.replace('gravatar:', '')) | |||
There was a problem hiding this comment.
ok then is the undefined value is handled in the subscription of this observable ?
There was a problem hiding this comment.
yes, I think l.25 below should handle it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gravatar service fetches the GN4 settings in the constructor, and then provides sync properties (
profileIcon,placeholder), whichThe PR refactors the service to returns Observables instead of values, which are triggered only if a subscription is done.
This means that the fetch for the avatar setting does not occur in web components.