Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Map-Viewer] Add layer from WMS service #768

Merged
merged 8 commits into from
Jan 17, 2024
Merged

[Map-Viewer] Add layer from WMS service #768

merged 8 commits into from
Jan 17, 2024

Conversation

ronitjadhav
Copy link
Collaborator

@ronitjadhav ronitjadhav commented Jan 15, 2024

This pull request adds the feature that allows users to add a layer from a Web Map Service (WMS) to their map.

  • Added a new add-layer-from-wms component in src/app/components/add-layer-from-wms/add-layer-from-wms.component.ts

  • The tab should initially contain a text input with a placeholder saying "Enter a WMS service URL"

  • Once a URL is entered in the text input, a loading indicator appears

  • Once the loading is finished, a list of layers show up below the text input; each layer should show its title (human readable), its identifier in smaller text, and an "Add" button

  • When clicking on the "Add" button of a layer, the layer should be added to the map, but the "Add layer" panel should stay open.

Screenshots:
image

image

Part of #756

@coveralls
Copy link

coveralls commented Jan 16, 2024

Coverage Status

coverage: 85.709% (-0.3%) from 85.968%
when pulling 4c64c0c on ronitjadhav:mv-add-from-wms
into c15a456 on geonetwork:main.

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, congratulations on your first contribution 🙂

@jahow jahow merged commit f866474 into geonetwork:main Jan 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants