Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete German translations #780

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Complete German translations #780

merged 4 commits into from
Jan 25, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Jan 24, 2024

Description

This PR completes and improves some German translations.

This work is sponsored by swisstopo.

@tkohr tkohr requested a review from Angi-Kinas January 24, 2024 12:36
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Affected libs: , Affected apps: ,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for translating this to German! Looks good overall, just a few little comments. Mostly suggestions, not a must.

translations/de.json Outdated Show resolved Hide resolved
translations/de.json Show resolved Hide resolved
translations/de.json Outdated Show resolved Hide resolved
translations/de.json Outdated Show resolved Hide resolved
@Angi-Kinas
Copy link
Collaborator

It looks like it's translating correctly:

image

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🚀

@Angi-Kinas Angi-Kinas merged commit e0d0f7a into main Jan 25, 2024
7 checks passed
@Angi-Kinas Angi-Kinas deleted the translations-de branch January 25, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants