Data service: better detect file formats from WFS outputs #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated links now have a 'download' type. Also the access protocol is now allowed on the download link model as well, which makes sense if we want to know what protocol the links goes through
… output, add GML and DXF formats The WFS services sometimes offer otuput formats like SHAPE-ZIP or GML2, and we need a more reliable way to infer a file format from them Use this in the data service to make sure we output known mime types from WFS and ESRI Rest
|
Affected libs:
|
jahow
commented
Feb 1, 2024
| @@ -45,7 +45,7 @@ interface WfsDownloadUrls { | |||
| export class DataService { | |||
| constructor(private proxy: ProxyService) {} | |||
|
|
|||
| private getDownloadUrlsFromWfs( | |||
| getDownloadUrlsFromWfs( | |||
There was a problem hiding this comment.
These changes were made to avoid TS errors in the corresponding test file
Angi-Kinas
approved these changes
Feb 1, 2024
cmoinier
approved these changes
Feb 1, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks the logic for inferring file formats from a list of output types provided by a WFS endpoints. WFS will typically advertise these kinds of formats:
With this PR, formats such as DXF, Shapefile and GML will now be recognized and show up properly in the Datahub download list.
Note that the DXF and GML formats were added to the list of recognized formats in the process.
Architectural changes
none
Screenshots
Quality Assurance Checklist
breaking changelabelbackport <release branch>labelThis work is sponsored by Géo2France.