Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use ogc-client for WMTS rendering #789

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Feb 2, 2024

Description

This PR uses the WMTS support from ogc-client to offload the WMTS parsing logic to the library.

Architectural changes

none

Screenshots

[...]

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Affected libs: feature-map, feature-dataviz, feature-record, feature-router, api-metadata-converter, api-repository, feature-catalog, feature-search, feature-auth, feature-editor, ui-search, data-access-datafeeder, util-data-fetcher, util-app-config, common-fixtures, util-shared, ui-elements, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map, data-access-gn4, common-domain, ui-dataviz, util-i18n,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@jahow
Copy link
Collaborator Author

jahow commented Feb 2, 2024

@fgravin what do you think of this? This would offload a lot of responsibility to the library.

@jahow jahow force-pushed the use-ogc-client-wmts branch 2 times, most recently from 4525d70 to e6ca0c6 Compare February 28, 2024 12:46
@jahow jahow added this to the 2.3.0 milestone Mar 13, 2024
Copy link
Contributor

github-actions bot commented Mar 27, 2024

📷 Screenshots are here!

@ronitjadhav ronitjadhav force-pushed the use-ogc-client-wmts branch 2 times, most recently from 5b9aff8 to 742b3aa Compare April 9, 2024 08:14
@ronitjadhav ronitjadhav merged commit 9f82dc5 into main Apr 16, 2024
6 of 7 checks passed
@jahow jahow deleted the use-ogc-client-wmts branch April 16, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants