Metadata Editor: rework pages and introduce an interactive table UI component #797
Conversation
|
Affected libs:
|
jahow
force-pushed
the
ME-open-edit-form
branch
from
dfc982b
to
c6dc707
Compare
...out/src/lib/interactive-table/interactive-table-column/interactive-table-column.component.ts
Show resolved
Hide resolved
jahow
force-pushed
the
ME-open-edit-form
branch
from
c6dc707
to
c9d6a78
Compare
jahow
force-pushed
the
ME-open-edit-form
branch
2 times, most recently
from
60e5e28
to
360f2c8
Compare
libs/feature/search/src/lib/results-table/results-table.component.html
Outdated
Show resolved
Hide resolved
libs/feature/search/src/lib/results-table/results-table.component.spec.ts
Show resolved
Hide resolved
| }) | ||
|
|
||
| describe('#handleRecordSelectedChange', () => { | ||
| it('should call selectRecords when checkbox is clicked', () => { |
There was a problem hiding this comment.
Possible misleading comment, as the click is not part of the test, if at some point the event is changed to another, the comment might not be changed.
libs/feature/search/src/lib/results-table/results-table.component.spec.ts
Outdated
Show resolved
Hide resolved
| it('returns false if no record selected', async () => { | ||
| selectionService.selectedRecordsIdentifiers$.next(['4', '5']) | ||
| expect(await firstValueFrom(component.isSomeSelected())).toBe(false) | ||
| }) |
There was a problem hiding this comment.
I don't understand this test compared to the previous one? Are there no selected records because 4 and 5 are not part of the possible selection? If so, this should be explicit in the description.
| } | ||
| } | ||
|
|
||
| async selectAll() { |
There was a problem hiding this comment.
Maybe rename to toggleCompleteSelection or toggleSelectAll, as this can deselect too.
apps/metadata-editor/src/app/my-org-users/my-org-users.component.spec.ts
Show resolved
Hide resolved
apps/metadata-editor/src/app/records/records-list.component.html
Outdated
Show resolved
Hide resolved
Also set a height for the dataviz table
…ve table Also fix the route
jahow
force-pushed
the
ME-open-edit-form
branch
from
360f2c8
to
b0eeb67
Compare
|
@LHBruneton-C2C I addressed all your comments I think, the fact is that this PR is only a partial refactoring of the dashboard view and there will probably be other ones later on to match the latest mockups, which is why I am not pushing this too far. Let me know if you feel that makes sense! |
There was a problem hiding this comment.
@jahow Thanks for the explanations! And great work, this is quite a beast.
|
Thanks for the extensive review 🙂 |
Description
This PR does:
gn-ui-interactive-tableUI component in ui/layout which is used both for records and users listsgn-ui-results-tablesmart component in feature/search which is bound to the search facade, shows a list of records and offers sorting options; also responsible for the selection/deselection of recordsArchitectural changes
Made several components standalone, removed the
gn-ui-record-tablecomponent which was too specific to the editor and isn't used anymore.Screenshots
Quality Assurance Checklist
breaking changelabelbackport <release branch>label